How to read multiple output file when using crop for ImageMagick

DEVENDRA SINGH RAWAT — Sat, 18 Jul 2020 12:18:14 -0000

I am trying a simple example to crop a image into multiple smaller images. Instead of creating the output files on disk (output file) I want to have it in OutputStream. I have tried few ways of doing the same but not successful. Any help will be benificial. Thanks for helping.

String imPath="C:/Program Files/ImageMagick-7.0.10-Q16-HDRI";
ConvertCmd cmd = new ConvertCmd();
cmd.setSearchPath(imPath);
ByteArrayOutputStream os = new ByteArrayOutputStream();
Pipe pipeOut = new Pipe(null, os);      
ArrayListOutputConsumer arrL = new ArrayListOutputConsumer(); //I tried this also in below but to no avail

cmd.setOutputConsumer(pipeOut);
IMOperation op = new IMOperation();
op.crop(256,256);

op.addImage("D:/matterport-sample-schematic-floor-plan/"+fileName); //Input file
op.addImage("png:-"); //output file
cmd.run(op);

BufferedImage bImage2 = ImageIO.read(new ByteArrayInputStream(os.toByteArray())); 
ImageIO.write(bImage2, "png", new File("D://matterport-sample-schematic-floor-plan/layered.png") ); //This writes only one output image.

Please note if i don't use Pipe (cmd.setOutputConsumer(pipeOut)) and put op.addImage() all cropped images are created on disk.

compare.run not working correctly. It is creating the files to be compared again instead of creating diff file

Mohit Agarwal — Wed, 18 Jul 2018 12:51:19 -0000

public static boolean compareImages(String actualImage,
String expectedImage, String diffImage) {
CompareCmd compare = new CompareCmd();
compare.setSearchPath("/usr/local/bin/");
ArrayListErrorConsumer errorConsumer = new ArrayListErrorConsumer();
compare.setErrorConsumer(errorConsumer); // for metric-output
IMOperation cmpOp = new IMOperation();
cmpOp.addImage("/Users/moagarwa/Desktop/delete/test/IMG_2188.JPEG");
cmpOp.addImage("/Users/moagarwa/Desktop/delete/test/IMG_2193.JPEG");
// cmpOp.fuzz(5.0);
cmpOp.metric("ae"); // root mean squared (normalized root mean
// squared)
cmpOp.addImage("/Users/moagarwa/Desktop/delete/DIFF.JPEG");
try {

            compare.run(cmpOp);
        } catch (Exception e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }

        return errorConsumer.getOutput().contains("0 (0)");

        Please help. We are doing mobile automation and we want to use it for image comparison.
        We are completely blocked

NullPointerException when using CompareCmd via Im4java

gabriele favaretto — Tue, 24 Oct 2017 11:34:15 -0000

I found the following bug in line 252 of ImageCommand.java there is no check if iErrorText is null:

protected void finished(int pReturnCode) throws Exception {
    if (pReturnCode > 0) {
      CommandException ce;
      if (iErrorText.size() > 0) { // this line
    ce = new CommandException(iErrorText.get(0));

I solved it as follows:

    protected void finished(int pReturnCode) throws Exception {
        if (pReturnCode > 0) {
            CommandException ce;
            if (iErrorText != null && iErrorText.size() > 0) {
                ce = new CommandException(String.join(",", iErrorText));
            } else {
                ce = new CommandException("return code: " + pReturnCode);
            }
            ce.setErrorText(iErrorText);
            ce.setReturnCode(pReturnCode);
            throw ce;
        } else {
            removeTmpFiles();
        }
    }

You can integrate this solution into your library?

Convert Operation Hangs on Specific Image

Eric Manzitti — Fri, 22 Sep 2017 19:02:53 -0000

Hi Bernard,

Thanks for the quick reply.

So we kept digging deeper and a coworker found that if she did the following, it worked.

                ConvertCmd cmd = new ConvertCmd();
                String enginePath = "C:\\Program Files\\ImageMagick-7.0.5-Q16";
                // create the operation, add images and operators/options
                IMOperation op = new IMOperation();
                op.addImage("C:\\WorkStuff\\badOriginal.jpeg");
                op.resize(800,600);
                op.addImage("C:\\WorkStuff\\fixedHappy2.jpg");
                // execute the operation
                cmd.setSearchPath(enginePath);
                cmd.run(op);

Moving one step at a time towards the broken code. We found it was the pipeIn that caused the problem.

Bernie (lol, hehe) ~ I think I'll go ahead and perhaps try to dig into that errorConsumer. I can't let that become production code, but if it'll help the open source, I'll dig into it and try to get you some more info.

As currently our solution is to modify the code to not use the pipe input. We don't seem to have a use case for why the Pipe object was used and so long as it tests fine without using the pipe, we're going that route.

<3 im4java and thanks for the reply.

Convert Operation Hangs on Specific Image

Bernhard Bablok — Fri, 22 Sep 2017 07:18:26 -0000

Hi Eric,

this is indeed strange. My first try would be to add an error-consumer. This might be the cause of the hang if the internal buffer for the stderr is not cleared. The output might also give some additional insights. This does not deal with the root-cause of course.

Bernhard

Convert Operation Hangs on Specific Image

Eric Manzitti — Thu, 21 Sep 2017 19:37:01 -0000

:::java

            System.out.println("We're going to get the image info.  For two images.");
            String incomingFileBad = "C:\\WorkStuff\\badOriginal444.jpeg";
            String incomingFileGood = "C:\\WorkStuff\\badRandomProp.jpeg";
            String incomingFileNormal = "C:\\WorkStuff\\001.jpg";
            String mimeType = "image/jpg";
            String enginePath = "C:\\Program Files\\ImageMagick-7.0.5-Q16";
            Info imageInfoBad = null;
            Info imageInfoGood = null;
            Info imageInfo3 = null;
            try {

// imageInfo = new Info (incomingFileBad, true);
// imageInfo2 = new Info (incomingFileGood, true);
// imageInfo3 = new Info (incomingFileNormal, true);

                imageInfoBad = new Info (incomingFileBad);
                imageInfoGood = new Info (incomingFileGood);
                imageInfo3 = new Info (incomingFileNormal);                 
            } catch (InfoException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }
            if (imageInfoBad != null) {

// System.out.println("We made it through the INFO gathering and here it is : " + imageInfo.toString());
// System.out.println("We made it through the INFO gathering and here it is : " + imageInfo2.toString());
// System.out.println("We made it through the INFO gathering and here it is : " + imageInfo3.toString());
System.out.println("Pause");
List<String> listOfDiffs = new ArrayList<String>();
boolean found = false;
Enumeration<String> badNames = imageInfoBad.getPropertyNames();
//Enumeration<String> goodNames = imageInfoGood.getPropertyNames();
int badNamesCounter = 0, goodNamesCounter =0;
while (badNames.hasMoreElements()){
String badFileProperty = badNames.nextElement();
goodNamesCounter =0;
//System.out.println(badFileProperty);
badNamesCounter++;
Enumeration<String> goodNames = imageInfoGood.getPropertyNames();
while (goodNames.hasMoreElements()){
String goodFileProperty = goodNames.nextElement();
//System.out.println(goodFileProperty);
goodNamesCounter++;
if (goodFileProperty.equals(badFileProperty)) {
found = true;
}
}
if (!found) {
listOfDiffs.add(badFileProperty);
}
found = false;
}
System.out.println("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~");
System.out.println("There were " + badNamesCounter + " bad image properties");
System.out.println("There were " + goodNamesCounter + " good image properties");
System.out.println("There were " + listOfDiffs.size() + " differences in good/bad properties");
System.out.println("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~");
if (listOfDiffs.size() > 0) {
for(String entry : listOfDiffs) {
System.out.println("Differing Property: " + entry);
}
} else {
System.out.println("No differing properties...");
}

:::

That produces the following output:
``
We're going to get the image info. For two images.
Pause

There were 151 bad image properties
There were 155 good image properties
There were 1 differences in good/bad properties

Differing Property: Properties:exif:Artist:exif:Copyright:exif:Flash
''

Now the difference betweent he two images is one is the bad image and one is that same image simply resaved (meaning It'll work)

So digging deeper here, it looks like perhaps that property causing image magik to get mad...

Convert Operation Hangs on Specific Image

Eric Manzitti — Thu, 21 Sep 2017 14:55:24 -0000

Oh sorry, here is the image file in question.

And a link to it:

https://drive.google.com/open?id=0B-9pALoPVAUeMmU1RWdpdVJvdkE

Convert Operation Hangs on Specific Image

Eric Manzitti — Thu, 21 Sep 2017 14:53:33 -0000

Hello. I have an instance where a specific image file is causing the convert.exe to hang. However when I run the same command through either the command line in Windows, or through a runtime execution inside java, the operation complets successfully.

The below code should indicate, I hope, that I am performing the same operation (in a local environment) between the im4java interface and the command line.

Super weird. I've tried an assortment of different commands in im4java, nothing seems to matter. Even just tried to 'resave' it.

Speaking of resaving. Whenever I modify the image in anyway, even a simple resaving, it then clears up whatever is wrong with the image and the im4java interface deals with it just fine.

Can anyone reproduce the hanging below? We first found this to be happening in our prod environment on a linux box.

Anyone happen to know or have an idea how I could try to detect the problem aspect(s) of this image before I send it to image magik through im4java? That way we dont have hanging threads out there?

            boolean runImageTest = true; 
            String domainName = "google.com";
            String command = "C:\\Program Files\\ImageMagick-7.0.5-Q16\\convert.exe C:\\WorkStuff\\badOriginal.jpeg -quality 40 C:\\WorkStuff\\fixedOriginal1.jpg";
            StringBuffer output = new StringBuffer();
            Process p;
            try {
                p = Runtime.getRuntime().exec(command);
                p.waitFor();
                BufferedReader reader =
                                new BufferedReader(new InputStreamReader(p.getInputStream()));

                            String line = "";
                while ((line = reader.readLine())!= null) {
                    output.append(line + "\n");
                }

            } catch (Exception e) {
                e.printStackTrace();
            }
            System.out.println(output.toString());

            if (runImageTest) {
                System.out.println("We're going to do some custom arguments");
                String myCommand = "quality";
                String incomingFile = "C:\\WorkStuff\\badOriginal.jpg";
                String outgoingFile = "C:\\WorkStuff\\fixedOriginal11.jpg";
                String mimeType = "image/jpg";
                double qualityValue = 05;
                String stylePath = "C:\\WorkStuff\\HMS.test.scales.csv";
                String enginePath = "C:\\Program Files\\ImageMagick-7.0.5-Q16";
                String style = "WIDTH";

                InputStream inputStream = null;
                CreatedFilesList imageReturnObject = null;
                OutputStream outputStream = null;
                try {
                    inputStream = new FileInputStream(incomingFile);
                    outputStream = new FileOutputStream(outgoingFile);
                    IMOperation imOperation = new IMOperation();
                    //imOperation.list("debug");
                    imOperation.addImage(FilenameUtils.getExtension(incomingFile) + ":-");              
                    imOperation.quality(qualityValue);              
                    imOperation.addImage(FilenameUtils.getExtension(outgoingFile) + ":-");

                    Pipe pipeIn = new Pipe(inputStream, null);
                    ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
                    Pipe pipeOut = new Pipe(null, byteArrayOutputStream);
                    ConvertCmd convertCmd = new ConvertCmd();
                    convertCmd.setInputProvider(pipeIn);
                    convertCmd.setOutputConsumer(pipeOut);
                    convertCmd.setSearchPath(enginePath);
                    System.out.println("We are about to start the operation");
                    convertCmd.run(imOperation);
                    outputStream.write(byteArrayOutputStream.toByteArray());
                } catch (Exception e) {
                    e.printStackTrace();
                } finally {
                    outputStream.close();
                    inputStream.close();
                }
                System.out.println("Holy Moly we made it through"); 
            }

Error converting PDF file unit test.

Bernhard Bablok — Sun, 29 Jan 2017 13:16:39 -0000

I'm a bit confused by "CommandException: magick". This suggests a new version of IM where all commands like "convert" are symlinks to "magick". Could you please check this? You could try to replace the symlinks with hardlinks. The magick-command behaves differently depending on the name it is called with, but im4java already resolves to the real name while searching for the command so this information gets lost.

Bernhard

Error converting PDF file unit test.

Tom — Wed, 25 Jan 2017 01:00:20 -0000

I'm getting the following error message when running my code from a Spring WebMvcTest. The code works correctly when called from my application, just not in the test. Code is:

    private byte[] createThumbnailImage(byte[] imageData, String imageFormat) throws ImageConversionException {

        ByteArrayOutputStream os = new ByteArrayOutputStream();

        try {
            InputStream is = new ByteArrayInputStream(imageData);

            IMOperation op = new IMOperation();
            op.addImage("-");
            op.thumbnail(THUMBNAIL_SIZE);

            if (imageFormat.equalsIgnoreCase(PDF_FILE_EXTENSION)) {
                op.background("white");
                op.alpha("remove");
                //create PNG image output for PDF files
                op.addImage(PNG_FILE_EXTENSION+":-");
            }
            else {
                op.addImage(imageFormat+":-");
            }

            Pipe pipeIn  = new Pipe(is,null);
            Pipe pipeOut = new Pipe(null,os);

            ConvertCmd convert = new ConvertCmd();
            convert.setInputProvider(pipeIn);
            convert.setOutputConsumer(pipeOut);
            convert.run(op);

        }
        catch (IOException | IM4JavaException | InterruptedException e) {

            if (e.getMessage().contains("Cannot run program \"convert\"")) {
                String message = "Imagemagick not found or not installed.";
                LOG.error(message);
                throw new ImageConversionException(message);
            }

            throw new ImageConversionException(e.getMessage());
        }

        return os.toByteArray();
    }

I can run the same test for an image file (.jpg) and it converts correctly, both in the test and when the application is running. When converting for a PDF the command passed to IM is:

- -thumbnail 255 -background white -alpha remove png:-

The command is the same both when running the application and when calling the same code from a unit test.

I have IM and Ghostscript installed locally. Could there be a problem with IM calling Ghostscript, or a Pipe wrapper problem from a unit test? Appreciate any help. Thanks,

Tom

Recent posts to Discussion

How to read multiple output file when using crop for ImageMagick

compare.run not working correctly. It is creating the files to be compared again instead of creating diff file

NullPointerException when using CompareCmd via Im4java

Convert Operation Hangs on Specific Image

Convert Operation Hangs on Specific Image

Convert Operation Hangs on Specific Image

Convert Operation Hangs on Specific Image

Convert Operation Hangs on Specific Image

Error converting PDF file unit test.

Error converting PDF file unit test.