#10 Allow acceptance of invalid ssl certificates

ScaryClam — Wed, 18 Dec 2013 15:00:05 -0000

Hi,

The project is now maintained over on github (https://github.com/scaryclam/python-webdav) so I've duplicated the issue there.

I see no problem with allowing developers to turn off the certification checking so I'll accept the changes.

Allow acceptance of invalid ssl certificates

Bryan "Crypt0s" Halfpap — Tue, 17 Dec 2013 22:04:15 -0000

Currently an invalid SSL certificate causes an error within the httplib2 library. A variable can be set to disable certificate validation in the httplib2.http() class.

Obviously certificate checking should be enabled by default. I propose the following patches:

diff old_connection.py new_connection.py

24a25

    self.check_cert = settings['check_cert']
28c29
< self.httpcon = httplib2.Http()

    self.httpcon = httplib2.Http(disable_ssl_certificate_validation=self.check_cert)

diff old_client.py new_client.py

17c17
< def init(self, webdav_server_uri, webdav_path='.', port=80, realm=''):

def __init__(self, webdav_server_uri, webdav_path='.', port=80, realm='',cert=True):
27c27
< port=port, realm=realm)

                                     port=port, realm=realm, check_cert=cert)

Recent changes to 10: Allow acceptance of invalid ssl certificates

#10 Allow acceptance of invalid ssl certificates

Allow acceptance of invalid ssl certificates

diff old_connection.py new_connection.py

diff old_client.py new_client.py