Recent changes to bugs

#14 mpFXYVector bug when vector is outside the bounding box

2023-10-13T04:45:41.948000Z

Here is a possible patch to fix this issue.
Any segment is dropped if both end points are on the same side either of the top, the bottom, the left or the right.

#14 mpFXYVector bug when vector is outside the bounding box

2023-01-08T21:04:47.701000Z

One solution is to remove the piece of code in charge of plotting only visible segments: lines 650 to 688 of mathplot.cpp@rev102 and just keep dc.DrawLine(x0, c0, x1, c1); and UpdateViewBoundary.
The drawback of this solution is that it will plot all segments even if they are not visible.

I wonder if detecting the intersection between each segment and one of the window borders is very interesting because it requires a lot of computations as well.

Which solution is the best?

mpFXYVector bug when vector is outside the bounding box

2023-01-05T16:17:30.399000Z

Hello
I found a bug with FXY when some breakpoints are outside the window, the shape is distorted.
Please find attached an example code drawing a diamond shape that you can move out of bounds and see the problem.
I will try to fix this issue.
Bests
Cedric

Crashes on Windows due to division by zero and log of negative number.

2022-11-02T14:16:44.066000Z

Hi all,

I've just started using this wxFreeChart (I needed the ability to create 100s of postage sized graphs). wxFreeChart is really fast an works almost perfectly.

The problem I have is that some times, the graphs are small. This causes crashes in the Plot function when w.GetScaleX() and w.GetScaleY() are less than zero.

    const double dig  = floor( log( 128.0 / w.GetScaleX() ) / mpLN10 );
    const double step = exp( mpLN10 * dig);
    const double end  = w.GetPosX() + (double)extend / w.GetScaleX();

It took me ages to figure out where the crash was happening, the Visual Studio debugger gave no clue about what had happened.

Here is the code needed to fix this.

    double fScale = w.GetScaleY();

    double dig = 0.0;
    if (fScale > 0.0)
        dig = floor(log(128.0 / fScale) / mpLN10);

    const double step = exp(mpLN10 * dig);
    double end = 0.0;
    if (fScale > 0.0)
        end = w.GetPosY() + (double)extend / fScale;




    double fScale = w.GetScaleX();

    double dig = 0.0;
    if (fScale > 0.0)
        dig = floor(log(128.0 / fScale) / mpLN10);

    const double step = exp( mpLN10 * dig);
    double end = 0.0;
    if (fScale > 0.0)
        end = w.GetPosX() + (double)extend / fScale;

There are a couple of other places as well where there is no check for division by zero (eg, "double changeUnitsX = change / m_scaleX;"). I'm more than happy to make these changes and commit them if I'm allowed to do so.

All the best,

Tony.

Minor issues in CMakeLists.txt

2021-11-29T13:39:58.365000Z

Hello
The project as well as the package name is named wxMathplot whereas the library file is named libmathplot, is it possible to rename the library libwxmathplot? It would be more in accordance.

Another problem is that under debian 64 bits, the package installs the .so file under /usr/lib64. The default config under debian is not to search under /usr/lib64. Is it possible to change lib64 to lib in CMakeLists.txt (line 93)?

#11 Compilation error on ::wxErrorLog calls

2017-01-20T22:53:35.086000Z

I too cannot build this at all, mostly due to the wxLog-related errors, using wx3.02 on Mint/Ubuntu 18.1.

Compilation error on ::wxErrorLog calls

2016-11-23T21:29:53.921000Z

Compilation of the library with wxWidget 3.0.2, on debian 8, fails with the errors in atachement, due to the ::wxErrorLog calls.
When i remove the global namespace (replace "::wxErrorLog" by "wxErrorLog"), the error disappear.

[PATCH] Initialize member variables in constructor

2015-03-27T07:29:47.028000Z

Please review the attached patch. It simply initializes all member variables of class mpMovableObject, in order to avoid potential usage of uninitialized member variable usage.

Best regards and thank you for the review

Martin Ettl

[PATCH] Fix wrong text position setting

2015-03-27T07:19:40.153000Z

Please review the attached patch. It fixes a potential copy&paste error, which led to wrong text positioning.

Best regards and many thanks for consider merging

Martin Ettl

Wrong description comment of mpBitmapLayer

2010-11-22T08:25:39Z

In mathplot.h revision 69, the description comment of mpBitmapLayer erroneously is just a copy of the one from mpMovableObject:

//-----------------------------------------------------------------------------
1610 // mpMovableObject - provided by Jose Luis Blanco
1611 //-----------------------------------------------------------------------------
1612 /** This virtual class represents objects that can be moved to an arbitrary 2D location+rotation.
1613 * The current transformation is set through SetCoordinateBase.
1614 * To ease the implementation of descendent classes, mpMovableObject will
1615 * be in charge of Bounding Box computation and layer render, assuming that
1616 * the object updates its shape in m_shape_xs & m_shape_ys.
1617 */
1618 class WXDLLIMPEXP_MATHPLOT mpBitmapLayer : public mpLayer
1619 {
...